feat(app push): add --build-tag flag for custom image tags#2909
Open
kwiatekus wants to merge 11 commits intokyma-project:mainfrom
Open
feat(app push): add --build-tag flag for custom image tags#2909kwiatekus wants to merge 11 commits intokyma-project:mainfrom
kwiatekus wants to merge 11 commits intokyma-project:mainfrom
Conversation
✅ Proposed changes verification passedThis pull request comes with up-to-date documentation and no illegal standard output usages. Find more detailed information in the |
kwiatekus
changed the title
musztardem
reviewed
May 8, 2026
| } | ||
| } | ||
|
|
||
| if apc.buildTag != "" { |
Contributor
There was a problem hiding this comment.
This lives in the complete method which as I understand is responsible for populating config data based on some logic. We don't populate the buildTag here but rather check if it's complaint with regex so I would move this piece to the validate method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--build-tagflag tokyma app pushallowing users to supply a custom Docker image tag when building from source (--code-pathor--dockerfile)--image(which already embeds the tag)[a-zA-Z0-9_], only[a-zA-Z0-9_.-]allowed, max 128 charsMotivation
Enables CI/CD pipelines to use deterministic, traceable image tags:
Closes #2907
Test Plan
go test ./internal/cmd/app/... -v— 15 tests pass (13 validation cases + 2 resolveImageTag cases)go build ./...— no errorskyma app push --name my-app --code-path . --build-tag abc1234uses tagabc1234kyma app push --name my-app --code-path .still uses timestamp tag (no regression)kyma app push --name my-app --image myimage:latest --build-tag abcfails with exclusivity errorkyma app push --name my-app --code-path . --build-tag "bad tag"fails with clear validation error